Skip to content

fix(integrations): properly handle exceptions in tool calls #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
constantinius merged 3 commits into from
Nov 5, 2025
Merged

fix(integrations): properly handle exceptions in tool calls #5065

constantinius merged 3 commits into from
Nov 5, 2025

Conversation

@constantinius
Copy link
Contributor

@constantinius constantinius commented Nov 4, 2025

Description

Properly wrap tool calls in try/except and capture exceptions so that the Sentry issues are actually linked to the tool calls
Also fixed issue related to tool call argument retrieval

Issues

Closes https://linear.app/getsentry/issue/TET-1357/issue-associated-with-invoke-agent-instead-of-execute-tool

Reminders

@constantinius constantinius requested a review from a team as a code owner November 4, 2025 15:10
@linear
Copy link

linear bot commented Nov 4, 2025

TET-1357 Issue associated with invoke_agent instead of execute_tool

@constantinius constantinius requested a review from a team November 4, 2025 15:11
@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.95%. Comparing base (e910302) to head (ea170e6).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ntry_sdk/integrations/pydantic_ai/patches/tools.py 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5065      +/-   ##
==========================================
+ Coverage   83.88%   83.95%   +0.07%     
==========================================
  Files         179      179              
  Lines       17916    17929      +13     
  Branches     3187     3188       +1     
==========================================
+ Hits        15029    15053      +24     
+ Misses       1914     1904      -10     
+ Partials      973      972       -1
Files with missing lines Coverage Δ
..._sdk/integrations/pydantic_ai/patches/agent_run.py 89.15% <100.00%> (-0.62%) ⬇️
sentry_sdk/integrations/pydantic_ai/utils.py 89.28% <100.00%> (+0.53%) ⬆️
...ntry_sdk/integrations/pydantic_ai/patches/tools.py 78.94% <83.33%> (-1.06%) ⬇️

... and 5 files with indirect coverage changes

@constantinius constantinius enabled auto-merge (squash) November 5, 2025 09:15
@constantinius constantinius merged commit e8d5f1b into master Nov 5, 2025
137 of 142 checks passed
@constantinius constantinius deleted the constantinius/fix/integrations/pydantic-ai-tool-call-issue branch November 5, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obostjancic obostjancic obostjancic approved these changes

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@constantinius @obostjancic @alexander-alderman-webb