Skip to content

feat: Enable HTTP request code origin by default #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexander-alderman-webb merged 3 commits into from
Oct 21, 2025
Merged

feat: Enable HTTP request code origin by default #4967

alexander-alderman-webb merged 3 commits into from
Oct 21, 2025

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Oct 21, 2025 •
edited
Loading

Description

See #4902 (comment).

We successfully trialed the option as part of version 2.42.0 of the SDK in Sentry: getsentry/sentry#101502

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner October 21, 2025 06:45
@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Oct 21, 2025
Merged
6 tasks
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23712 1 23711 1713
View the top 1 failed test(s) by shortest run time 
tests.integrations.redis.test_redis_cache_module::test_key_as_string[key7-]
Stack Traces | 0.006s run time 
.../integrations/redis/test_redis_cache_module.py:318: in test_key_as_string
    assert _key_as_string(key) == expected_key
E   AssertionError: assert 'Ǟ\x04$k\x06Hԗ\x01ݒ{/\x1f\x14' == ''
E     + Ǟ#x04$k#x06Hԗ#x01ݒ{/#x1F#x14

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft October 21, 2025 06:46
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review October 21, 2025 07:08
@alexander-alderman-webb alexander-alderman-webb merged commit dcd94ed into master Oct 21, 2025
119 of 121 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/enable-http-request-source-by-default branch October 21, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-alderman-webb @sentrivana