Skip to content

Fix parse_url#2161

Merged
antonpirker merged 7 commits intomasterfrom
ivana/urlparse-fix
Jun 7, 2023
Merged

Fix parse_url#2161
antonpirker merged 7 commits intomasterfrom
ivana/urlparse-fix

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 7, 2023

We're already splitting the URL while sanitizing. No need to reassemble and then disassemble it again, which also prevents #2160

Tested locally on 3.11.4

Fixes #2160

@sentrivana sentrivana marked this pull request as ready for review June 7, 2023 15:06
@antonpirker antonpirker enabled auto-merge (squash) June 7, 2023 15:33
@antonpirker antonpirker merged commit dd6bbe0 into master Jun 7, 2023
@antonpirker antonpirker deleted the ivana/urlparse-fix branch June 7, 2023 15:38
@antonpirker
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.11.4 (and maybe others) break sentry-sdk's URL parsing that contains filtered elements

2 participants