Modify Version parsing in integrations#1354
Closed
ohe wants to merge 8 commits intogetsentry:masterfrom
Closed
Conversation
ohe
force-pushed
the
bug/fix-version-parsing
branch
from
421c59b to
3b29143
Compare
… control lib/framework version (getsentry#1095)
ohe
force-pushed
the
bug/fix-version-parsing
branch
from
3b29143 to
be71c48
Compare
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix issue #1095 by implementing the Python versioning scheme defined by PEP 440 without making
sentry-sdkdependent to thepackaginglibrary.The version parsing have been tested, for each integration with recent project versions.
During the implementation of these test, a few amount of tests in integration folder were broken. This PR is also fixing them.