Update metric normalization#1729
Merged
Merged
Conversation
Member
Author
|
@stayallive When you look at the linked docs, regarding Line Feed, Carriage Return and Tab. |
Collaborator
|
You can right... So technically you can, but it's a stretch anyone would do it on purpose. But should also be easy to replace right? Something like |
markushi
reviewed
Apr 8, 2024
# Conflicts: # src/Serializer/EnvelopItems/MetricsItem.php
cleptric
marked this pull request as ready for review
April 10, 2024 11:59
stayallive
approved these changes
Apr 10, 2024
stayallive
left a comment
stayallive
left a comment
Collaborator
There was a problem hiding this comment.
Code wise this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://develop-git-statsd-unicode-escapes.sentry.dev/sdk/metrics/#normalization
closes #1731