feat(tracing): Drop unfinished spans from a transaction#635
Closed
relaxolotl wants to merge 23 commits intotracing/basic-spansfrom
Closed
feat(tracing): Drop unfinished spans from a transaction#635relaxolotl wants to merge 23 commits intotracing/basic-spansfrom
relaxolotl wants to merge 23 commits intotracing/basic-spansfrom
Conversation
relaxolotl
force-pushed
the
tracing/omit-unfinished-spans
branch
2 times, most recently
from
ff00824 to
9e9ed29
Compare
loewenheim
approved these changes
Dec 20, 2021
relaxolotl
force-pushed
the
tracing/basic-spans
branch
from
e32d01e to
d07e1f0
Compare
relaxolotl
force-pushed
the
tracing/omit-unfinished-spans
branch
from
9e9ed29 to
8f8ee90
Compare
Swatinem
reviewed
Dec 21, 2021
Contributor
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
This ties in with my comment on the previous PR in this chain:
If we only ever record spans in finish (that means that start only creates the object but otherwise does nothing) this whole PR would become obsolete.
relaxolotl
force-pushed
the
tracing/basic-spans
branch
from
d07e1f0 to
14ec096
Compare
relaxolotl
force-pushed
the
tracing/basic-spans
branch
3 times, most recently
from
0bec560 to
8969d44
Compare
relaxolotl
force-pushed
the
tracing/basic-spans
branch
2 times, most recently
from
1dd00df to
3208c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all unfinished spans from transactions as they're being processed and sent over the wire to sentry. This addresses a TODO left behind in #634.
related to #601
picks up off of #634