fix: remove spurious decref in sentry_capture_user_feedback()#1510
Merged
fix: remove spurious decref in sentry_capture_user_feedback()#1510
sentry_capture_user_feedback()#1510Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Remove `sentry_value_decref(user_report)` from `prepare_user_report()` fail path. The caller already decrefs unconditionally, so having it in both places caused a use-after-free on failure. Co-Authored-By: Claude Opus 4.6 <[email protected]>
jpnurmi
force-pushed
the
jpnurmi/fix/user-report-decref
branch
from
7927d69 to
af3aaed
Compare
jpnurmi
changed the title
jpnurmi
changed the title
sentry_capture_user_feedback()
tustanivsky
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
sentry_value_decref(user_report)fromprepare_user_report()fail path.sentry_capture_user_feedback()already decrefs unconditionally, so having it in both places caused a use-after-free on failure.The newer variant
sentry_capture_feedback()had a similar issue, which was found by @tustanivsky in #1414 (comment). Notice the difference thatsentry__envelope_add_user_feedback()takes ownership of the value, butsentry__envelope_add_user_report()does not (it only serializes it).