Skip to content

test: mark test_breakpad_dump_inflight as flaky with timeout#1505

Merged
jpnurmi merged 1 commit into
masterfrom
jpnurmi/test/breakpad-dump-inflight
Feb 6, 2026
Merged

test: mark test_breakpad_dump_inflight as flaky with timeout#1505
jpnurmi merged 1 commit into
masterfrom
jpnurmi/test/breakpad-dump-inflight

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Add a 5-minute timeout, which should be generous enough even for busy CI environments, and retry up to 3 times to prevent the test from hanging indefinitely, or 6 hours in CI.

Close: #1501

MiniDumpWriteDump can deadlock on Windows due to loader lock
contention (see #1501). Add a 5-minute timeout and retry up to 3
times to prevent the test from hanging indefinitely in CI.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@jpnurmi

jpnurmi commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

Example:

===Flaky Test Report===
test_breakpad_dump_inflight failed (2 runs remaining out of 3).
	<class 'subprocess.TimeoutExpired'>
	Command '['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\cmake26\\sentry_example.exe', 'log', 'capture-multiple', 'crash']' timed out after 300.0 seconds
	[<TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\runner.py:340>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\flaky\flaky_pytest_plugin.py:146>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_hooks.py:512>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_manager.py:120>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_callers.py:167>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_callers.py:139>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\threadexception.py:87>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\threadexception.py:63>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_callers.py:139>, <TracebackEntry C:\hostedtoolcache\windows\Python\3.12.1
test_breakpad_dump_inflight passed 1 out of the required 1 times. Success!
test_shutdown_timeout passed 1 out of the required 1 times. Success!
===End Flaky Test Report===
================ 903 passed, 22 skipped in 1681.44s (0:28:01) =================

@JoshuaMoelans JoshuaMoelans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jpnurmi
jpnurmi merged commit 6de36f6 into master Feb 6, 2026
223 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/test/breakpad-dump-inflight branch February 6, 2026 12:50
BernhardMarconato pushed a commit to elgatosf/sentry-native that referenced this pull request Apr 21, 2026
…ry#1505)

MiniDumpWriteDump can deadlock on Windows due to loader lock
contention (see getsentry#1501). Add a 5-minute timeout and retry up to 3
times to prevent the test from hanging indefinitely in CI.

Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Windows (Old VS, 32-bit) hangs

2 participants