test: skip basic_transport_thread_name test on NX platform#1439
Merged
Conversation
The basic_transport_thread_name test fails on NX (Nintendo Switch) because the transport won't start without a custom network_connect_func. This change adds a platform check to skip the test on NX, preventing false test failures on that platform. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
vaind
changed the title
JoshuaMoelans
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skips the
basic_transport_thread_nametest on NX (Nintendo Switch) platform to prevent false test failures.Changes
SENTRY_PLATFORM_NXcheck to skip the test in tests/unit/test_basic.c:309-311Background
The
basic_transport_thread_nametest cannot run on NX because the transport won't start without a customnetwork_connect_func. Rather than failing the test, we now skip it on this platform where it's not applicable.🤖 Generated with Claude Code