fix: correct sentry__process_spawn signature in none implementation#1436
Merged
fix: correct sentry__process_spawn signature in none implementation#1436
Conversation
PR #1413 changed the arg0 parameter from sentry_pathchar_t* to char* as part of making narrow UTF-8 the canonical path encoding, but the signature in sentry_process_none.c was not updated. This fixes the function signature to match the declaration, changing arg0 from `const sentry_pathchar_t *` to `const char *`. Fixes regression from #1413 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Added unreleased section with fixes for PS5/Switch compilation regression.
JoshuaMoelans
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in #1413 where the
sentry__process_spawnfunction signature insentry_process_none.cwas not updated to match the new canonical path encoding.Changes
arg0parameter fromconst sentry_pathchar_t *toconst char *insentry_process_none.c:6Background
PR #1413 changed path handling to use narrow UTF-8 as the canonical encoding, updating function signatures throughout the codebase. The no-op implementation in
sentry_process_none.cwas missed in that refactor, causing a signature mismatch.🤖 Generated with Claude Code