fix(win): make narrow utf-8 the canoncial path encoding by supervacuus · Pull Request #1413 · getsentry/sentry-native

supervacuus · 2025-10-13T11:41:04Z

Fixes #1397 (which also contains an explanation of the approach followed in this PR).

src/path/sentry_path_windows.c

src/process/sentry_process_windows.c

supervacuus · 2025-10-13T14:20:51Z

@JoshuaMoelans, can you give this a first once over? This is not fully completed according to the scope I had in mind. Still, the PR reflects the most significant portion requiring restructuring, and I would appreciate some SDK internals WTF count from your POV.

JoshuaMoelans

This looks pretty good on a first viewing. A few minor comments about some cleanup & clarification.

src/sentry_path.h

tests/unit/test_fuzzfailures.c

src/sentry_path.h

src/sentry_string.c

src/path/sentry_path_windows.c

JoshuaMoelans

LGTM!

Just a few typo/consistency nits, and adding some const (see #1422) and updating the new logs-on-crash tests to use the expect_failure argument too (#1421)

include/sentry.h

src/path/sentry_path_windows.c

src/sentry_string.c

supervacuus · 2025-10-23T13:43:12Z

I don't know what is going on with the cursor bot today, but the "bugs" it raises are pure gold:

#1413 (comment)
Why is the comment misleading? It specifies what the function assumes, and the "bug" description verifies (the client includes the null-termination in the length argument). And regarding the more critical (after the seemingly less critical aspect): let call-sites allocate means that this is a static helper, and the translation-unit call-sites are responsible for maintaining path_w. The call site and the static helper are written and used by the same role.

#1413 (comment)
What is confusing is the cursor bot text. It has a very long-winded way of saying in the "bug" description that the code does what it's supposed to. And then raises a concern with its taste buds.

#1413 (comment)
This is very intentional because assignments often trigger static analysis warnings when used in a condition.

And so densely written, it is a pleasure to decipher. This is clearly the future of software development 🤗

* sentry__filewriter_byte_count now takes a const filewriter * sentry__path_filename always returns a char.

Co-authored-by: JoshuaMoelans <[email protected]>

cursor · 2025-10-23T15:53:05Z

Bug: Crash Reporter: Redundant Conditional Compilation

The Windows version of the crash reporter uses wmain but the non-Windows version uses main. However, both versions end with #ifdef _WIN32 blocks that call _wremove(path) on Windows and remove(path) on non-Windows. The problem is that in the Windows wmain version, path is a wchar_t *, but in the non-Windows main version, path is a char *. This means the #ifdef _WIN32 block at line 100-104 is checking the wrong condition - it's inside a function that's only compiled on Windows (wmain), so the #ifdef _WIN32 is redundant and the #else branch will never execute. This appears to be a logic error in the conditional compilation structure.

…P instead of explict wide to multibyte conversion)

…or _MSC_VER

…tances are still running

tests/__init__.py

src/path/sentry_path_windows.c

src/sentry_string.c

PR #1413 changed the arg0 parameter from sentry_pathchar_t* to char* as part of making narrow UTF-8 the canonical path encoding, but the signature in sentry_process_none.c was not updated. This fixes the function signature to match the declaration, changing arg0 from `const sentry_pathchar_t *` to `const char *`. Fixes regression from #1413 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

…1436) * fix: correct sentry__process_spawn signature in none implementation PR #1413 changed the arg0 parameter from sentry_pathchar_t* to char* as part of making narrow UTF-8 the canonical path encoding, but the signature in sentry_process_none.c was not updated. This fixes the function signature to match the declaration, changing arg0 from `const sentry_pathchar_t *` to `const char *`. Fixes regression from #1413 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Update CHANGELOG with unreleased fixes Added unreleased section with fixes for PS5/Switch compilation regression. --------- Co-authored-by: Claude <[email protected]>

seer-by-sentry bot reviewed Oct 13, 2025

View reviewed changes

src/path/sentry_path_windows.c Show resolved Hide resolved

src/process/sentry_process_windows.c Show resolved Hide resolved