Skip to content

Conversation

@JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Oct 9, 2025

Fixes #1407

We (mistakenly) assumed that the paragraph in the logs documentation stating Make sure to always convert 64-bit unsigned integers to strings applied to all unsigned integers, but this is only an issue for log attributes. For all other values, we can safely ingest these.

We change the jsonwriter to write the actual numerical value again, and update sentry_logs to store unsigned integers as string sentry_value_t objects.

ToDo:

  • ✅ update logs code to store unsigned ints as sentry_value_t strings instead

@JoshuaMoelans JoshuaMoelans changed the title fix: serialize uint64 values as numerical instead of string fix: serialize uint64_t values as numerical instead of string Oct 10, 2025
@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review October 10, 2025 08:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@JoshuaMoelans JoshuaMoelans merged commit 596b702 into master Oct 13, 2025
66 of 67 checks passed
@JoshuaMoelans JoshuaMoelans deleted the joshua/feat/send_uint64_as_number branch October 13, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling of uin64_t values as strings causes processing errors during ingestion

3 participants