fix(logs): add logs flush on crash #1404
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…crash # Conflicts: # CHANGELOG.md # tests/test_integration_crashpad.py
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
this eliminates boilerplate noise in the tests but also reduces the chance of forgetting it in a test.
… it since we flush anyway.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
supervacuus
left a comment
supervacuus
left a comment
There was a problem hiding this comment.
LGTM ❤️
The only thing I ask you to do now is to reduce the logs or move them to the TRACE level.
… cleaning in the pytest configuration
this means when it does its clearing a TEST_CHECK cannot assume that a directory even exists (in which case clear_crash_marker would actually fail versus the case were only the marker file didn't exist).
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@JoshuaMoelans, do you still want to add something here, or is this ready to merge from your point of view? |
|
@supervacuus good to go from my perspective! 🚀 |
Fixes #1403
Part of #1398