fix: compilation error if SENTRY_TEST_PATH_PREFIX is defined#1279
Merged
Conversation
Collaborator
|
Ouch, I wrongly assumed that this conditional path was somewhere stressed here. Yes, we should add a dummy test to include that path. While missing the macro-continuation backslashes was an accident, the removal of the last semicolon was intentional. |
vaind
marked this pull request as draft
June 23, 2025 18:24
vaind
commented
Jun 24, 2025
vaind
marked this pull request as ready for review
June 25, 2025 07:43
supervacuus
approved these changes
Jun 25, 2025
supervacuus
left a comment
supervacuus
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just the semicolon.
vaind
commented
Jun 25, 2025
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
…ry#1279) * fix: compilation error if SENTRY_TEST_PATH_PREFIX is defined * run unit tests with custom path prefix * linter issue * fix cmake.py * Update tests/unit/sentry_testsupport.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken accidently in #1234 but there is no code path that matches in this repo so I've only found this out when trying to integrate in a downstream SDK. Should we add a test python script or sth?
#skip-changelog