feat: support attaching bytes#1275
Merged
Merged
Conversation
|
Collaborator
|
If we want to stay consistent with other SDKs, |
jpnurmi
force-pushed
the
feat/attach-data-buffer
branch
from
June 17, 2025 07:21
fc2a84c to
90f233b
Compare
jpnurmi
force-pushed
the
feat/attach-data-buffer
branch
from
June 17, 2025 07:44
90f233b to
9e3dd5e
Compare
> warning C4190: 'to_crashpad_attachment' has C-linkage specified, > but returns UDT 'crashpad::Attachment' which is incompatible with C
jpnurmi
commented
Jun 18, 2025
6 tasks
type & content_type are passed separately and content_type is cloned in sentry__attachments_add()
jpnurmi
changed the title
jpnurmi
marked this pull request as ready for review
June 19, 2025 08:22
jpnurmi
commented
Jun 19, 2025
jpnurmi
commented
Jun 19, 2025
supervacuus
requested changes
Jun 20, 2025
supervacuus
left a comment
supervacuus
left a comment
Collaborator
There was a problem hiding this comment.
This looks nice, thanks! A couple of minor points and one thing that is probably just a limit of my imagination.
supervacuus
reviewed
Jun 24, 2025
supervacuus
reviewed
Jun 24, 2025
supervacuus
approved these changes
Jun 24, 2025
supervacuus
left a comment
supervacuus
left a comment
Collaborator
There was a problem hiding this comment.
I don't know if you'd still like to add anything, but from my end, this is ready to be released.
Collaborator
Author
|
I don't have anything else in mind regarding attachments. We should now have everything that was requested. Thanks for your time reviewing yet another big PR. |
1 task
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
* feat: Support attaching bytes * fix: move to_crashpad_attachment out of extern C > warning C4190: 'to_crashpad_attachment' has C-linkage specified, > but returns UDT 'crashpad::Attachment' which is incompatible with C * fix: lint * fix: unreachable * test: integration * test: rename * test: attaching bytes to crashpad is supported on win32 and linux * crashpad: dump byte attachments on disk * fix: windows * let crashpad ensure unique file names * fix sentry__attachment_from_buffer * clean up unused uuid * Update external/crashpad * alternative: ensure unique file in sentry_backend_crashpad * clean up * clean up more * switch to std::filesystem * fix leaks in backends * add sentry__attachment_from_path for convenience and to reduce diff * fix self-review findings * revert accidental ws changes * fix attachment_clone type & content_type are passed separately and content_type is cloned in sentry__attachments_add() * unit-testable sentry__path_unique() to back the "-N.tar.gz" claims * include <string> * ref: unique paths for byte attachments * add note about unique file names with crashpad * add missing null checks for screenshots * attachment_clone: add missing error handling * add note and missing test for buffer attachment comparison * Bump external/crashpad * Update external/crashpad * attachment_eq: clarify with a comment * document behavior regarding duplicate attachments * sentry__attachments_remove: replace attachment_eq with ptr cmp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q: Should it be calledsentry_attach_bufferorsentry_attach_data?A:
sentry_attach_bytesTODO:
Crashpad: IPCfeat: support attaching bytes on Windows and Linux crashpad#127(write files instead due to IPC limits)