feat: thread context from breakpad on macos#1083
Merged
supervacuus merged 3 commits intomasterfrom Nov 20, 2024
Merged
Conversation
…on macOS from the breakpad backend.
|
…reakpad backend.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 82.36% 82.38% +0.02%
==========================================
Files 53 53
Lines 7752 7751 -1
Branches 1216 1216
==========================================
+ Hits 6385 6386 +1
+ Misses 1255 1253 -2
Partials 112 112
|
This was referenced Dec 10, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
breakpaddoesn't provide the thread context to the handler callbacks (it does write it to the minidump, though). This change fills the context of the crashed thread and passes it on to the handler callback (which in turn passes it on to theon_crashandbefore_sendcallbacks).The change keeps compatibility between upstream and our fork in both directions even though this breaks one of the public interfaces:
breakpadbackend in the Native SDK uses the upstream interface ifSENTRY_BREAKPAD_SYSTEMis definedbreakpadfork provides the modified interface only if compiled with the Native SDK (i.e.,SENTRY_BACKEND_BREAKPADis defined in thebreakpad_clienttarget).