-
-
Notifications
You must be signed in to change notification settings - Fork 201
Closed
Labels
Description
Description
We have discovered that crashes due to stack overflow are not uploaded to Sentry. The application silently crash without any additional details reported.
When does the problem happen
- During build
- During run-time
- When capturing a hard crash
Environment
- OS: Windows 10 and later, 32-bit
- Compiler: MSVC2022
- vcpkg, 0.7.2, also applies to older versions
Steps To Reproduce
Generate stack overflow by allocating all available stack and then calling into any function.
Log output
None.
Mitigations
After discovering this issue we applied several mitigations:
- Increased stack size to reduce probability
- Reserve one extra stack page for recovery
SetThreadStackGuarantee - Inject SEH handler that calls
_resetstkoflwto avoid subsequent crash in error handling
However, I would very much prefer that this situations was handled also with "naive" integration.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Projects
Status
No status