Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.7.10
Choose a base ref
...
head repository: getsentry/sentry-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.7.12
Choose a head ref
  • 18 commits
  • 38 files changed
  • 8 contributors

Commits on Sep 23, 2024

  1. Merge branch 'release/0.7.10'

    getsentry-bot
    getsentry-bot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    dbb9580 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. feat: check validity of trace- and span-id in context update from hea…

    …der (#1046)
    
    * Added draft test scenario for invalid trace_id
    
    * test: invalid span id from header test cases
    
    * feat: trace- and span-id checks in context update from header
    
    * chore: format code
    
    * fix: free memory of string on invalid input
    
    * test: add empty span-id test
    
    * fix: free memory of parent_span_id on invalid input
    
    * chore: update CHANGELOG.md
    
    * chore: add warning on invalid input
    
    * test: use correct string to compare expected span_id with
    
    * Apply suggestions from code review
    
    * chore: format updated code
    
    * chore: update CHANGELOG.md
    JoshuaMoelans authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    65bfb62 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    f0d2a66 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. fix: adjusted memcpy size param to match remaining destination size (#…

    …1047)
    
    * fix: adjusted memcpy size param to match remaining destination size
    
    * fix: add null termination character
    JoshuaMoelans authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    21c6d0a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix: look up GetSystemTime() implementations at runtime. (#1051)

    * fix: look up `GetSystemTime()` implementations at runtime.
    
    * Add calling convention.
    supervacuus authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b555a97 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. fix: don't fail crashpad startup on invalid DSN (#1059)

    * fix: allow for empty DSN to start crashpad handler
    
    * chore: format code
    
    * chore: format code
    
    * fix: no unnecessary string wrap
    
    Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
    
    * chore: typo
    
    * chore: remove unnecessary warn
    
    * chore: format
    
    * chore: update CHANGELOG.md
    
    ---------
    
    Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
    JoshuaMoelans and supervacuus authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0dbf198 View commit details
    Browse the repository at this point in the history
  2. Setup CodeQL (#1058)

    markushi authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    66e5aae View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    c6aca87 View commit details
    Browse the repository at this point in the history
  2. fix: remove a potential overflow before conversion (#1062)

    * fix: remove a potential overflow before conversion
    
    This is in response to CodeQL security scan alert #1-#3.
    
    `Elf[32|64]_Ehdr[.e_phnum|.e_phentsize|.e_shnum|.e_shentsize]` are all `uint16_t`, this means the loop-var `i` is bounded by `uint16_t` and should fit in a `uint32_t` (to prevent unsigned overflow in the loop). A switch to unsigned still makes sense, because we reduce the future chance of unnecessary signed overflow (=UB) in the loop body.
    
    All program/section-header table entry sizes are cast to `uin64_t` even though the multiplication is bound to `uint32_t` by both factors being bound by `uint16_t`. This fixes the potential overflow before conversion to the bigger type.
    
    * also safely cast the access to section header string table.
    supervacuus authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a0663a6 View commit details
    Browse the repository at this point in the history
  3. release: 0.7.11

    getsentry-bot committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    33739b5 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'release/0.7.11'

    getsentry-bot
    getsentry-bot committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b598af0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. chore: add clang-format to venv (#1066)

    * chore: make format
    
    * roll-back linter changes in CI
    
    * chore: add clang-format to venv
    
    * more references to clang-format
    vaind authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3244b9e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    341a64f View commit details
    Browse the repository at this point in the history
  2. feat: add breadcrumb ringbuffer to avoid O(n) memmove (#1060)

    * feat: initial ringbuffer implementation
    
    * chore: cleanup code
    
    * chore: added todo
    
    * removed unnecessary buffer end value
    
    * changed buffer start_idx storage to [0]
    
    * fixed issues in new storing method
    
    * updated test to new ringbuffer append logic
    
    * refactor: renamed to sentry__value_append_ringbuffer
    
    * test: removed old bounded append test
    
    * chore: update CHANGELOG.md
    
    * chore: update CHANGELOG.md
    
    * chore: linting
    
    * increase refcount of ringbuffer-to-list items
    
    * apply suggestion from code review
    
    * added ringbuffer test
    
    * fixed ringbuffer to list conversion
    
    * direct access to ringbuffer items
    
    * updated test with proper refcount check
    
    * removed unnecessary decref from test
    
    * added decref of temporary ringbuffer list
    
    * removed double cloning
    
    * changing types from int32_t to size_t
    
    * moved declaration from public to private header
    
    * added decref
    
    * type conversion
    
    * applied suggestions from code review
    JoshuaMoelans authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ffdf6ed View commit details
    Browse the repository at this point in the history
  3. feat: expose function to send minidumps (#1067)

    * feat: programmatic minidump capture
    
    This provides a new function that will allow for independently created minidumps to be captured by sentry
    
    Resolves: #1050
    
    * fixed compile errors
    
    * Rework of programmatic minidumps based on feedback
    
    * Remove unused parameters
    
    * Address Lint errors
    
    * Address more review feedback
    
    * Address Lint errors
    
    * Address more lint errors
    
    * changed from bool to int due to undefined errors
    
    * Address review feedback
    
    * Work on addressing feedback, example and test
    
    * Fixes to lint errors
    
    * Apply comment suggestion
    
    * Add empty line to file end
    
    * use parameter directly
    
    * chore: fix changelog
    
    * add capture_minidump_n
    
    * feat: capture minidump from path
    
    * chore: update changelog
    
    * cleanup
    
    * linter issues
    
    * cleanup, review changes, docs
    
    * chore: fixup doc
    
    * Update CHANGELOG.md
    
    ---------
    
    Co-authored-by: PlasmaDev5 <[email protected]>
    Co-authored-by: PlasmaDev5 <[email protected]>
    3 people authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d61acdd View commit details
    Browse the repository at this point in the history
  4. docs: clarify macOS support of the inproc backend (#1072)

    * docs: clarify macOS support of the `inproc` backend
    
    * apply review feedback + minor wording fixes
    
    * reference advanced usage section
    supervacuus authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ad6df21 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. ci: replace macos-12 action runners (#1073)

    * ci: replace macos-12 action runners
    
    * add listing installed images to android start script
    
    * specify path to android tools for sdkmanager
    
    * use cmdline-tools for sdkmanager + avdmanager
    
    * switch to macos-14 since macos-15 has no android cmd-tools
    
    * try x64 macos images
    
    * list sdkmanager images and try to update to check if tooling works at all
    
    * switch back to macos-15 verify installable setup
    
    * remove update from android start script again
    
    * ensure images are installed
    
    * accept android image licenses automatically
    
    * pre-accept licenses
    
    * start the emulator blocking so we can see any issues during startup
    
    * check emulator acceleration before starting the emulator
    
    * switch back x86[_64] images
    
    * re-enable emulator run in background
    
    * expose llvm18 bin directory for macos15 runners on PATH
    
    * revert last commit to macos-15 only
    
    * fix quotes
    
    * bump old android api/ndk
    
    * lower end android on x86_64 + llvm-cov on macos-15-large
    
    * android lower end only available on x86 + increase timeout to 20 minutes
    
    * install NDK package together with target image
    
    * update lower end android to API level 21 (keep NDK23)
    
    * switch lower end to API 35 but keep NDK at 23
    
    * max API for NDK23 is 31 (but the emulator started)
    
    * define adb and emulator ports
    
    * introduce emulator and adb port to start script
    
    * use ADB_SERVER_PORT as the env variable from the workflow
    
    * start also the non-blocking emulator with the right port
    
    * get rid of lower emulator test
    
    * get rid of emulator and adb port in start-android.sh
    supervacuus authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    683201f View commit details
    Browse the repository at this point in the history
  2. release: 0.7.12

    getsentry-bot committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bf14b85 View commit details
    Browse the repository at this point in the history
Loading