fix(remix): Fix express Request and Response types
#5758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-fix-remix-express-types
branch
from
3749cd3 to
db1a5c0
Compare
AbhiPrasad
reviewed
Sep 16, 2022
lobsterkatie
force-pushed
the
kmclb-fix-remix-express-types
branch
2 times, most recently
from
99a5a10 to
1d2daa5
Compare
lobsterkatie
force-pushed
the
kmclb-fix-remix-express-types
branch
from
1d2daa5 to
93e006e
Compare
AbhiPrasad
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, this issue (wherein the
RequestandResponsetypes from express claim never to have heard of standard properties likeheaders) flared up in our remix tests. It turns out the culprit was that a few days ago, DefinitelyTyped removed TS 4.0 support from a number of packages, among them@types/express-serve-static-core(upon which@types/expressdepends).Key changes in this fix:
@types/express-serve-static-coreto the last version before this change.@types/expressto@sentry/remix's dev dependencies (where it should have been all along).@types/expressto latest. (Not strictly necessary, but done as part of my debugging. Doesn't seem to break anything, and we might as well be up to date.)