ref(core): Actually ensure attachments are added to the envelope#5159
Merged
Lms24 merged 1 commit intogetsentry:7.xfrom May 25, 2022
Merged
ref(core): Actually ensure attachments are added to the envelope#5159Lms24 merged 1 commit intogetsentry:7.xfrom
Lms24 merged 1 commit intogetsentry:7.xfrom
Conversation
Lms24
approved these changes
May 24, 2022
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Good catch, thanks for fixing it!
timfish
force-pushed
the
fix/attachments-api
branch
from
e0ae896 to
f7ea38c
Compare
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This patch fixes a bug where attachments were previously not added to the envelope that would be sent to Sentry. Additionally, it adds a test that ensures that the attachments actually make it into the raw envelope.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake and didn't reassign the envelope as items were added to it. The result is that attachments were never added!
This PR fixes the mistake and adds a test that ensures that the attachment actually makes it into the raw envelope.