ref(core): Test mutation of attachments in hint#5140
Merged
lforst merged 4 commits intogetsentry:7.xfrom May 25, 2022
Merged
Conversation
AbhiPrasad
approved these changes
May 19, 2022
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Yeah - making the hint required would clean this up a lot, I wonder the consequences it would have though 🤔.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@timfish Is this up for merging? |
Collaborator
Author
|
Yes! |
Collaborator
Author
|
Although actually if #5141 gets merged first I can clean this up a little. |
Contributor
|
Alright, I'll review #5141 and merge it first since it has more changes in general. Feel free to ping me here when this is ready to go :) |
Collaborator
Author
|
This is ready to merge once CI completes! |
Contributor
|
Awesome, thank you Tim! |
|
Hi, do we have any forecast when version 7.x will be released on npm? |
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Closed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to ensure attachments get passed from scope and through
beforeSend/Event processors in the hint object.PR #5004