ref(serverless): Do not throw on flush error#5090
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
force-pushed
the
lforst-catch-serverless-flush-errors
branch
from
1a728a6 to
28fb0a2
Compare
lforst
force-pushed
the
lforst-catch-serverless-flush-errors
branch
from
69a5eae to
7caf12b
Compare
AbhiPrasad
approved these changes
May 12, 2022
Lms24
approved these changes
May 13, 2022
This was referenced May 13, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a number of issues on the fact that we fail or stall serverless functions when anything goes wrong while flushing:
Considering our fire & forget mantra for events, this PR changes the behaviour of our lambda/cloud function wrappers to catch and log errors that occur while flushing. Up until now we threw upwards if something went wrong while flushing.
Todo after merging: Remove https://docs.sentry.io/platforms/node/guides/aws-lambda/#ignore-sentry-errors section
Ref: https://getsentry.atlassian.net/browse/WEB-918