fix(integrations): Mark ExtraErrorData as already normalized#5053
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
force-pushed
the
lforst-extra-error-data-respect-depth-option
branch
4 times, most recently
from
d122d29 to
87bcd3c
Compare
AbhiPrasad
approved these changes
May 9, 2022
lforst
force-pushed
the
lforst-extra-error-data-respect-depth-option
branch
from
5117312 to
87bcd3c
Compare
lforst
force-pushed
the
lforst-extra-error-data-respect-depth-option
branch
from
87bcd3c to
cffd0f4
Compare
Closed
9 tasks
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
depthoption of theExtraErrorDataintegration by skipping normalization of extra error data in subsequent normalization runs.Previously, the client option
normalizeDepthunintentionally had precedence over the integration'sdepthoption. It truncated entire event objects up to the specifiednormalizeDepth, including the extra error data, even though the user specified a specific depth for the extra error data using the integration's options. With this PR, extra error data will now always be normalized to the depth specified by theExtraErrorDatadepthoption.Ref: https://getsentry.atlassian.net/browse/WEB-600