fix(serverless): Adjust v6 Lambda layer hotfix for v7#5006
Merged
Conversation
- add or adjust .npmignore paths to all sentry dependencies of @sentry/serverless - add basic documentation to `build-awslambda-layer.js`
Contributor
size-limit report 📦
|
Lms24
changed the title
lforst
approved these changes
Apr 28, 2022
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
Still kinda want the lambda layer to just build its own bundles but this looks good in the meanwhile. Thanks for cleaning up that file!
Lms24
changed the title
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
- ensure that the `s/dist/cjs` change is applied to the .npmignore files added and to build-awslambda-layer.js - add or adjusts .npmignore files in all Sentry packages that are dependencies of @sentry/serverless therefore, the unnecessary source, test or config files that previously bloated the lambda layer zip are no longer present - improve the build-awslambda-layer.js script by improving documentation and changing variable names to be more expressive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the hotfix for the Lambda layer creation introduced in 6.19.7 (in #4982) for v7.
More specifically, this PR
s/dist/cjschange is applied to the.npmignorefiles added in fix(serverless): Re-add missing modules in Node AWS Lambda Layer #4982 and tobuild-awslambda-layer.js.npmignorefiles in all Sentry packages that are dependencies of@sentry/serverlessbuild-awslambda-layer.jsscript byref: https://getsentry.atlassian.net/browse/WEB-871