Closed
Conversation
added 6 commits
April 27, 2022 15:36
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly aims to add back client reports to the SDK using the new transports:
Contents
transport.send()returnvoidinstead of response information. We do not need that information.DropReasontype to use in place ofOutcometo be more in line with our docs. Outcome is a very overloaded term.Outcomenow describes an "outcome object" like the docs use the term:Response,EventStatus,SentryRequestType,SentryRequesttypes - were not needed anymoreDataCategorytype in favor ofTransportCategoryto be more in line with the docs. We use it for client outcome categories and rate limit categories.EnvelopeItemTypetype.envelopeItemTypeToDataCategoryto map from envelope item types to data categories. This mapping is taken from the python SDK.eventStatusFromHttpCodefunction. It is not needed anymore.