ref(browser): Remove showReportDialog on browser client#4973
Merged
AbhiPrasad merged 1 commit into7.xfrom Apr 28, 2022
Merged
Conversation
Contributor
size-limit report 📦
|
lobsterkatie
force-pushed
the
7.x
branch
2 times, most recently
from
0040b0f to
299aeb3
Compare
AbhiPrasad
force-pushed
the
v7-abhi-report-dialog-client
branch
from
eb39c3e to
53f6b9e
Compare
AbhiPrasad
requested review from
a team,
Lms24 and
lforst
and removed request for
a team
lforst
approved these changes
Apr 28, 2022
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
Remove `showReportDialog` as a client method so it can be tree-shaken out if not used. Also allow for hub to be explicitly passed in to `showReportDialog`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
showReportDialogas a client method so it can be tree-shaken out if not used. Also allow for hub to be explicitly passed in toshowReportDialog.Resolves https://getsentry.atlassian.net/browse/WEB-819