Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
force-pushed
the
v7-abhi-delete-minimal
branch
from
02af0fa to
215d57d
Compare
AbhiPrasad
force-pushed
the
v7-abhi-invoke-client
branch
from
8a02b12 to
3908bca
Compare
lforst
approved these changes
Apr 26, 2022
AbhiPrasad
force-pushed
the
v7-abhi-invoke-client
branch
from
3908bca to
41bbcf6
Compare
AbhiPrasad
force-pushed
the
v7-abhi-invoke-client
branch
from
41bbcf6 to
fd4c840
Compare
AbhiPrasad
changed the title
AbhiPrasad
force-pushed
the
v7-abhi-invoke-client
branch
from
fd4c840 to
ea35dc3
Compare
AbhiPrasad
force-pushed
the
v7-abhi-invoke-client
branch
from
ea35dc3 to
120b19c
Compare
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
This PR removes the dynamic dispatch of `_invokeClient` in favour of explicitly using client methods. We introduce a `_withClient` helper that does this. `_withClient` grabs the client and scope from the stack of scopes on the hub, and executes a callback with those values. This allows the consumer of the function to directly access the client instance and call methods on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See earlier work in #4195
Dependent on #4971
This PR removes the dynamic dispatch of
_invokeClientin favour of explicitly using client methods. We introduce a_withClienthelper that does this._withClientgrabs the client and scope from the stack of scopes on the hub, and executes a callback with those values. This allows the consumer of the function to directly access the client instance and call methods on it.There are a couple consequences of this change
Resolves https://getsentry.atlassian.net/browse/WEB-463