Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
force-pushed
the
v7-abhi-delete-old-transports
branch
from
817a118 to
4e64c8d
Compare
AbhiPrasad
force-pushed
the
v7-abhi-delete-store
branch
2 times, most recently
from
f8d5392 to
88eac76
Compare
lforst
approved these changes
Apr 26, 2022
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
Looks good. A general concern of mine is that the envelope file is completely untested.
| /** | ||
| * Create an Envelope from an event. | ||
| */ | ||
| export function createEventEnvelope( |
Contributor
There was a problem hiding this comment.
We should def write tests for the functions in this file. Don't know whether this PR is the place for this tho. Wdyt?
Contributor
Author
There was a problem hiding this comment.
Yes, we should write tests - I can write up a ticket after this gets merged in.
AbhiPrasad
force-pushed
the
v7-abhi-delete-old-transports
branch
from
5ad27a4 to
dac51b7
Compare
AbhiPrasad
force-pushed
the
v7-abhi-delete-store
branch
from
88eac76 to
6d3043a
Compare
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete all code related to store endpoint.
Built on top of work in #4967
Resolves https://getsentry.atlassian.net/browse/WEB-557