feat(tracing): Add GB unit to device memory tag value#4935
Conversation
dashed
requested review from
AbhiPrasad and
lobsterkatie
and removed request for
a team
|
@lobsterkatie @AbhiPrasad Unsure if this is something we could add to v7 release 👀 |
size-limit report 📦
|
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Is this something that would fit better as a custom measurement? I guess we don't index measurements in the same way as tags though (at least not yet).
As per #4882, we are targeting it so that all changes get merged into 7.x branch. We can merge this in for v7!
I intentionally set this as a tag as it's easier to do with minimal complexity. But it might be transitioned once metrics product is more fleshed out.
I'll see if I can rebase this PR to |
Yes please, that would be great! |
dashed
force-pushed
the
add-gb-units-to-device-memory
branch
from
f90ba85 to
aa91d09
Compare
|
@AbhiPrasad I've rebased it against |
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
AbhiPrasad
changed the title
|
@AbhiPrasad thanks! Is there a tentative timeline for the v7 release? Just something I can communicate back to the team for this fix. |
|
First betas are our end of Q1 - then 2-3 weeks of testing until full release prob. |
Since tag values are always strings, it'll be useful to attach units to the `deviceMemory` tag. Since `navigator.deviceMemory` are approximate in gigabytes, we can suffix the tag value with " GB". Reference: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory
Since tag values are always strings, it'll be useful to attach units to the `deviceMemory` tag. Since `navigator.deviceMemory` are approximate in gigabytes, we can suffix the tag value with " GB". Reference: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory
Since tag values are always strings, it'll be useful to attach units to the `deviceMemory` tag. Since `navigator.deviceMemory` are approximate in gigabytes, we can suffix the tag value with " GB". Reference: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory
Since tag values are always strings, it'll be useful to attach units to the `deviceMemory` tag. Since `navigator.deviceMemory` are approximate in gigabytes, we can suffix the tag value with " GB". Reference: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory
2 participants
Since tag values are always strings, it'll be useful to attach units to the
deviceMemorytag. Sincenavigator.deviceMemoryare approximate in gigabytes, we can suffix the tag value with " GB".When seeing these values in Sentry product, it's non-obvious that they're in gigabytes:
Reference: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory