feat(core): Introduce seperate client options#4927
Merged
AbhiPrasad merged 33 commits into7.xfrom Apr 19, 2022
Merged
Conversation
AbhiPrasad
force-pushed
the
v7-options-from-client
branch
2 times, most recently
from
213eb37 to
129b929
Compare
Contributor
size-limit report 📦
|
Contributor
Author
|
We've decided to hold off on this until we finish the transport/client changes! |
AbhiPrasad
force-pushed
the
v7-options-from-client
branch
from
129b929 to
622e1e7
Compare
AbhiPrasad
requested review from
a team,
lforst and
lobsterkatie
and removed request for
a team
AbhiPrasad
force-pushed
the
v7-options-from-client
branch
from
ddb0329 to
f3bce9e
Compare
AbhiPrasad
commented
Apr 19, 2022
| stackParser: stackParserFromOptions(options), | ||
| integrations: getIntegrationsToSetup(options), | ||
| // TODO(v7): get rid of transport being passed down below | ||
| transport: options.transport || (supportsFetch() ? FetchTransport : XHRTransport), |
Contributor
Author
There was a problem hiding this comment.
this is a huge hack, but given we are switching to the new transports, left it as is.
Contributor
Author
lforst
reviewed
Apr 19, 2022
Lms24
approved these changes
Apr 19, 2022
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM now. Approving this but since I also worked on it, someone else should probably approve, too.
lforst
approved these changes
Apr 19, 2022
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 21, 2022
This PR works toward differentiating the options that are passed into `Sentry.init` and the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor. We do this by explicitly differentiating between the options that are configured in sdk init (`Options`) and the options that are passed into the client constructor (`ClientOptions`).
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 21, 2022
This PR works toward differentiating the options that are passed into `Sentry.init` and the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor. We do this by explicitly differentiating between the options that are configured in sdk init (`Options`) and the options that are passed into the client constructor (`ClientOptions`).
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
This PR works toward differentiating the options that are passed into `Sentry.init` and the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor. We do this by explicitly differentiating between the options that are configured in sdk init (`Options`) and the options that are passed into the client constructor (`ClientOptions`).
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
This PR works toward differentiating the options that are passed into `Sentry.init` and the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor. We do this by explicitly differentiating between the options that are configured in sdk init (`Options`) and the options that are passed into the client constructor (`ClientOptions`).
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
This PR works toward differentiating the options that are passed into `Sentry.init` and the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor. We do this by explicitly differentiating between the options that are configured in sdk init (`Options`) and the options that are passed into the client constructor (`ClientOptions`).
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
This PR works toward differentiating the options that are passed into `Sentry.init` and the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor. We do this by explicitly differentiating between the options that are configured in sdk init (`Options`) and the options that are passed into the client constructor (`ClientOptions`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works toward differentiating the options that are passed into
Sentry.initand the options passed into clients. We want to make this differentiation to minimize internal state in the client, and instead rely on the max number of items being passed in to the client constructor.We do this by explicitly differentiating between the options that are configured in sdk init (
Options) and the options that are passed into the client constructor (ClientOptions).After this gets merged in, there are a couple next steps here:
initfunctions to reduce bundlegetIntegrationsToSetupso it doesn't rely on the entire options object anymoredefaultIntegrationsto a simple booleaninitRawfunctionPart 1 of https://getsentry.atlassian.net/browse/WEB-843