Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Apr 12, 2022
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
Looks great! I was wondering if we should just make _setupTransport in the base client abstract and get rid of NoopTransport but let's just do this when we inject the transports into the client.
Member
Author
|
Yup, I agree, it would be good to get rid of it. But as you said, this should be done in a separate PR (I'm already working on injecting the Transports). |
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 13, 2022
Delete the Backend classes. Specifically the following classes and files are removed: * `Backend (interface)` * `BaseBackend`* * `BrowserBackend` * `NodeBackend` * `TestBackend`* *`Options` interfaces in these files were moved to the respective Client files Additionally, * delete (the previously ported) `NoopTransport` test in packages/browser/test/unit/backend.test.ts. * adjust a few remaining Backend references in tests to use Client classes * adjust `BaseBackend` documentation to no longer include Backend information
Lms24
added a commit
that referenced
this pull request
Apr 26, 2022
Delete the Backend classes. Specifically the following classes and files are removed: * `Backend (interface)` * `BaseBackend`* * `BrowserBackend` * `NodeBackend` * `TestBackend`* *`Options` interfaces in these files were moved to the respective Client files Additionally, * delete (the previously ported) `NoopTransport` test in packages/browser/test/unit/backend.test.ts. * adjust a few remaining Backend references in tests to use Client classes * adjust `BaseBackend` documentation to no longer include Backend information
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Delete the Backend classes. Specifically the following classes and files are removed: * `Backend (interface)` * `BaseBackend`* * `BrowserBackend` * `NodeBackend` * `TestBackend`* *`Options` interfaces in these files were moved to the respective Client files Additionally, * delete (the previously ported) `NoopTransport` test in packages/browser/test/unit/backend.test.ts. * adjust a few remaining Backend references in tests to use Client classes * adjust `BaseBackend` documentation to no longer include Backend information
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Delete the Backend classes. Specifically the following classes and files are removed: * `Backend (interface)` * `BaseBackend`* * `BrowserBackend` * `NodeBackend` * `TestBackend`* *`Options` interfaces in these files were moved to the respective Client files Additionally, * delete (the previously ported) `NoopTransport` test in packages/browser/test/unit/backend.test.ts. * adjust a few remaining Backend references in tests to use Client classes * adjust `BaseBackend` documentation to no longer include Backend information
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Delete the Backend classes. Specifically the following classes and files are removed: * `Backend (interface)` * `BaseBackend`* * `BrowserBackend` * `NodeBackend` * `TestBackend`* *`Options` interfaces in these files were moved to the respective Client files Additionally, * delete (the previously ported) `NoopTransport` test in packages/browser/test/unit/backend.test.ts. * adjust a few remaining Backend references in tests to use Client classes * adjust `BaseBackend` documentation to no longer include Backend information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the porting of Backend functionality to Client in #4911, this PR now deletes the Backend classes. Specifically the following classes and files are removed:
Backend(interface)BaseBackend*BrowserBackendNodeBackendTestBackend**
Optioninterfaces in these files were moved to the respective Client filesAdditionally,
packages/browser/test/unit/backend.test.ts.BaseBackenddocumentation was adjusted to no longer include Backend informationref: https://getsentry.atlassian.net/browse/WEB-462