build(bundles): Stop publishing CDN bundles on npm#4901
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
requested changes
Apr 8, 2022
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
This theoretically is enough but there is the temporary bundle copy section in prepack.ts which we should remove as well. Additionally, the --skipBundleCopy flag is used in WASM which we don't need any longer either.
Contributor
Author
Thank you! I knew I missed something. |
Lms24
changed the title
lforst
changed the title
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude CDN bundles from being published on npm by including them in
.npmignore.Ref: https://getsentry.atlassian.net/browse/WEB-674