[v7] feat: Delete deprecated startSpan and child methods#4849
Merged
AbhiPrasad merged 2 commits into7.xfrom Apr 7, 2022
Merged
[v7] feat: Delete deprecated startSpan and child methods#4849AbhiPrasad merged 2 commits into7.xfrom
startSpan and child methods#4849AbhiPrasad merged 2 commits into7.xfrom
Conversation
AbhiPrasad
force-pushed
the
v7-tracing-deprecations
branch
from
b1ea897 to
8ca7f7c
Compare
AbhiPrasad
force-pushed
the
v7-tracing-deprecations
branch
from
8ca7f7c to
d4e81b7
Compare
Contributor
size-limit report 📦
|
lforst
approved these changes
Apr 5, 2022
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
lgtm but can we maybe get some more context on why we're deleting these methods? The PR description is probably fine for this.
Contributor
Author
|
Amending the PR description to reference to the original PR, thanks for calling that out. |
Contributor
Thank you! |
Lms24
pushed a commit
that referenced
this pull request
Apr 7, 2022
Lms24
pushed a commit
that referenced
this pull request
Apr 7, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 7, 2022
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
k-fish
added a commit
to getsentry/jest-sentry-environment
that referenced
this pull request
May 10, 2022
It looks like we were using a deprecated 'child()' syntax, see getsentry/sentry-javascript#4849.
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated methods
startSpanandchild.These deprecated methods were removed in favour of
span.startChildin #2600Resolves https://getsentry.atlassian.net/browse/WEB-553