ref(build): Add debug constants in each package individually#4842
Merged
ref(build): Add debug constants in each package individually#4842
Conversation
AbhiPrasad
approved these changes
Apr 4, 2022
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
We need to find a place to write this down in the repo. Can we update CONTRIBUTING.md accordingly?
Contributor
size-limit report 📦
|
Member
|
This looks good. My only suggestion would be to explain (in the comment at the top of each |
billyvg
added a commit
to getsentry/sentry-replay
that referenced
this pull request
Apr 8, 2022
Replaced with a constant that can be treeshaked. See getsentry/sentry-javascript#4842
billyvg
added a commit
to getsentry/sentry-replay
that referenced
this pull request
Apr 8, 2022
Replaced with a constant that can be treeshaked. See getsentry/sentry-javascript#4842
lobsterkatie
added a commit
that referenced
this pull request
Apr 9, 2022
In #4842, a `flags.ts` file was added to each package to fix logger treeshaking when using webpack. Because of the way that webpack works, this file has to exist separately in each individual package, including in `@sentry/integrations`. It is not itself an integration, though, so we shouldn't be building a separate CDN bundle for it (let alone six versions of one). This fixes the build script so that we're no longer doing that.
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
In #4842, a `flags.ts` file was added to each package to fix logger treeshaking when using webpack. Because of the way that webpack works, this file has to exist separately in each individual package, including in `@sentry/integrations`. It is not itself an integration, though, so we shouldn't be building a separate CDN bundle for it (let alone six versions of one). This fixes the build script so that we're no longer doing that.
lobsterkatie
added a commit
that referenced
this pull request
Apr 26, 2022
In #4842, a `flags.ts` file was added to each package to fix logger treeshaking when using webpack. Because of the way that webpack works, this file has to exist separately in each individual package, including in `@sentry/integrations`. It is not itself an integration, though, so we shouldn't be building a separate CDN bundle for it (let alone six versions of one). This fixes the build script so that we're no longer doing that.
lobsterkatie
added a commit
that referenced
this pull request
Apr 26, 2022
In #4842, a `flags.ts` file was added to each package to fix logger treeshaking when using webpack. Because of the way that webpack works, this file has to exist separately in each individual package, including in `@sentry/integrations`. It is not itself an integration, though, so we shouldn't be building a separate CDN bundle for it (let alone six versions of one). This fixes the build script so that we're no longer doing that.
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
In #4842, a `flags.ts` file was added to each package to fix logger treeshaking when using webpack. Because of the way that webpack works, this file has to exist separately in each individual package, including in `@sentry/integrations`. It is not itself an integration, though, so we shouldn't be building a separate CDN bundle for it (let alone six versions of one). This fixes the build script so that we're no longer doing that.
mydea
pushed a commit
that referenced
this pull request
Nov 23, 2022
Replaced with a constant that can be treeshaked. See #4842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've identified that our current way of importing
isDebugBuild()from@sentry/utilsis difficult some build tooling (ie. weback) to tree shake.As we want to facilitate tree shaking of unwanted code for users as much as possible, this PR will:
isDebugBuildfunction to a constIS_DEBUG_BUILDRef: https://getsentry.atlassian.net/browse/WEB-769