chore: Use white Sentry logo in all README when GH dark mode #4575
chore: Use white Sentry logo in all README when GH dark mode #4575timfish wants to merge 1 commit intogetsentry:masterfrom
Conversation
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
This is great! @chadwhitacre shall we roll this out to all the repos?
AbhiPrasad
changed the title
|
What will happen on npm? 🤔 |
|
Oh good point. Will two logos show up? Lol. I wonder if we have a test package we can test with. |
|
Unfortunately, I think this will result in multiple logos 😭. It looks like nextjs solve this issue with a black and white logo that just works for |
|
Let me ask the design folks, maybe they have some ideas. |
Oh nice. Might still be an issue for other package managers 🤷♂️ |
|
oh yes. Because the text is invisible it gives the impression otherwise! |
| <p align="center"> | ||
| <a href="https://sentry.io" target="_blank" align="center"> | ||
| <a href="https://sentry.io#gh-light-mode-only" target="_blank" align="center"> | ||
| <img src="https://sentry-brand.storage.googleapis.com/sentry-logo-black.png" width="280"> |
There was a problem hiding this comment.
Oh |
|
You can actually include CSS in an SVG that switches fill on dark mode but it will follow the browser mode rather than the Github/npm theme which obviously won't match at times 😞 |
4 participants
Docs here and community help here.
You can see the result here.