Merged
Conversation
JonasBa
approved these changes
Jan 17, 2022
Member
JonasBa
left a comment
JonasBa
left a comment
There was a problem hiding this comment.
Thanks for handling this @AbhiPrasad!
AbhiPrasad
force-pushed
the
abhi-add-back-severity-enum
branch
2 times, most recently
from
94b266a to
cbfc5a8
Compare
Contributor
size-limit report
|
In #4280, specifically in commit dd3aa70, we deprecated the `Severity` enum in favour of using a string union type, `SeverityLevel`. It's important to note that this change affected the type signature of one of our public API methods, `captureMessage`. The change to deprecate the `Severity` enum was done for bundle size reasons. After releasing the beta with these changes, it was found that deprecating the `Severity` enum and replacing it with `SeverityLevel` was quite the disruptive change, which would make upgrading to the minor version a hassle for users. As a result, this patch undeprecates the `Severity` enum. The `Severity` enum will be removed in the upcoming major release instead, as a breaking change.
AbhiPrasad
force-pushed
the
abhi-add-back-severity-enum
branch
from
cbfc5a8 to
5d95081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4280,
specifically in commit dd3aa70, we
deprecated the
Severityenum in favour of using a string union type,SeverityLevel. It's important to note that this change affected thetype signature of one of our public API methods,
captureMessage.The change to deprecate the
Severityenum was done for bundle sizereasons.
After releasing the beta with these changes, it was found that
deprecating the
Severityenum and replacing it withSeverityLevelwas quite the disruptive change, which would make upgrading to the minor
version a hassle for users. As a result, this patch undeprecates the
Severityenum. TheSeverityenum will be removed in the upcomingmajor release instead, as a breaking change.