Merged
Conversation
No need to roll a version of this module when a better one is available. This has the added benefit of allowing `assert` to assert the `test` param.
9 tasks
Contributor
Author
|
I believe these fails aren't due to the changes in this pull request. I think if you modify your ember-try config to use ember-auto-import v2 you'll fix these scenarios on your master branch too. |
Member
|
@jherdman Yeah I was just looking, it's because Ember 4.0 came out and requires auto-import 2. It's a breaking change though since auto import 2.0 isn't backwards compatible as far as I am aware. |
k-fish
approved these changes
Nov 23, 2021
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
It passes the rest of the scenarios, so at least the next minor version will be fixed 👍 . We will probably address Ember 4 (and the auto import changes) in another PR.
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
No need to roll a version of this module when a better one is available. This has the added benefit of allowing `assert` to assert the `test` param. Will address Ember 4 (and the auto import changes) in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to roll a version of this module when a better one is available. This has the added benefit of allowing
assertto assert thetestparam.