ref(offline integration): Move event listener setup from constructor to setupOnce#2889
Merged
lobsterkatie merged 2 commits intogetsentry:masterfrom Sep 11, 2020
Conversation
piotr-cz
changed the title
2 tasks
lobsterkatie
approved these changes
Sep 11, 2020
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
You're correct - this should be done in setupOnce. Thanks for the fix!
lobsterkatie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event listener should be set up after hub is set on instance (in
setupOncemethod) as event may be fired before hub is set (hub is used in_sendEvents).IMHO it's bad practice to have business logic in constructor.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).