fix(browser): Allow SDK initialization in NW.js apps#12846
Merged
Conversation
s1gr1d
approved these changes
Jul 10, 2024
mydea
approved these changes
Jul 10, 2024
Contributor
size-limit report 📦
|
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like our browser extension check that blocks SDK initalization via
Sentry.initalso blocked initializingthe SDK in NW.js apps. This PR adds a check for the
window.nwproperty to handle this case.Note: If we get more reports like this, we should consider adding a flag to force-init the SDK when this
check wrongfully blocks sdk init. For now though, I wanna hold off from expanding public API.
fixes #12668