feat(v8/serverless): Use subpath exports package#10561
Closed
AbhiPrasad wants to merge 6 commits intodevelopfrom
Closed
feat(v8/serverless): Use subpath exports package#10561AbhiPrasad wants to merge 6 commits intodevelopfrom
AbhiPrasad wants to merge 6 commits intodevelopfrom
Conversation
AbhiPrasad
commented
Feb 7, 2024
| ".": { | ||
| "import": { | ||
| "default": "./build/npm/esm/index.js", | ||
| "types": "./build/npm/types/index.d.ts" |
Contributor
Author
There was a problem hiding this comment.
in the future this will be *.mjs fwiw
AbhiPrasad
commented
Feb 7, 2024
| package: '@sentry/serverless', | ||
| package: '@sentry/serverless/aws', | ||
| exports: Object.keys(SentryServerless), | ||
| ignoreExports: ['cron', 'hapiErrorPlugin', 'enableAnrDetection'], |
Contributor
Author
There was a problem hiding this comment.
I will add another e2e test to validate the subpath exports if we are fine with this approach.
Member
|
I don't have a strong opinion, but I think I tend to say let's maybe just make these dedicated packages. As logically otherwise e.g. react/vue/svelte could also just be subpath exports from browser 🤔 But maybe serverless is also simply "less important" and it's good enough this way - not sure. |
Contributor
|
I am with Francesco on this one. No hard opinions but dedicated packages would make a bit more sense to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a direct follow up to #10540, where I refactored the serverless package to use subpath exports.
Does this API feel reasonable to you? Should we go a step further and just publish separate packages?