fix: remove chunked streaming mode #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
============================================
- Coverage 71.58% 71.57% -0.01%
Complexity 1294 1294
============================================
Files 134 134
Lines 4726 4725 -1
Branches 489 489
============================================
- Hits 3383 3382 -1
Misses 1087 1087
Partials 256 256
Continue to review full report at Codecov.
|
Contributor
Author
|
@bruno-garcia do you think this is worth to patch on v2? not every on-premise installs are able to do a server migration as well. |
Member
Sounds like a good idea. Given that's a regression. |
bruno-garcia
approved these changes
Oct 12, 2020
maciejwalkowiak
approved these changes
Oct 12, 2020
marandaneto
added a commit
to getsentry/sentry-android
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: remove chunked streaming mode
💡 Motivation and Context
some http servers have limitations and this was experienced on on-premise v9.x
https://docs.oracle.com/javase/8/docs/api/java/net/HttpURLConnection.html#setChunkedStreamingMode-int-
reported by @ninniuz
💚 How did you test it?
running it
📝 Checklist
🔮 Next steps