Add profiling to more samples, add E2E Tests#4969
Merged
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| d15471f | 302.62 ms | 353.84 ms | 51.22 ms |
| 9fbb112 | 404.51 ms | 475.65 ms | 71.14 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
| fc5ccaf | 276.52 ms | 370.46 ms | 93.93 ms |
| d15471f | 369.38 ms | 459.08 ms | 89.70 ms |
| 9139b91 | 351.35 ms | 355.63 ms | 4.28 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| fc5ccaf | 270.49 ms | 363.90 ms | 93.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 9139b91 | 1.58 MiB | 2.13 MiB | 559.52 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
Previous results on branch: feature/profiling-in-samples-and-system-test
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90ef31c | 291.34 ms | 363.52 ms | 72.18 ms |
| d838b5a | 348.75 ms | 425.94 ms | 77.19 ms |
| 6829062 | 288.84 ms | 353.44 ms | 64.60 ms |
| 18e412b | 352.65 ms | 455.36 ms | 102.71 ms |
| 1624838 | 336.10 ms | 449.19 ms | 113.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90ef31c | 1.58 MiB | 2.13 MiB | 559.19 KiB |
| d838b5a | 1.58 MiB | 2.13 MiB | 559.20 KiB |
| 6829062 | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 18e412b | 1.58 MiB | 2.13 MiB | 559.20 KiB |
| 1624838 | 1.58 MiB | 2.13 MiB | 559.20 KiB |
adinauer
approved these changes
Dec 16, 2025
| assertEquals(person.lastName, returnedPerson!!.lastName) | ||
|
|
||
| testHelper.ensureTransactionReceived { transaction, envelopeHeader -> | ||
| profilerId = transaction.contexts.profile?.profilerId |
Member
There was a problem hiding this comment.
is this a leftover from creating the test? should we remove it here since it's not asserting and the other test is actually asserting
….com:getsentry/sentry-java into feature/profiling-in-samples-and-system-test
….com:getsentry/sentry-java into feature/profiling-in-samples-and-system-test
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| mapOf( | ||
| "SENTRY_DSN" to testHelper.dsn, | ||
| // "SENTRY_AUTO_INIT" to "false", | ||
| // "SENTRY_AUTO_INIT" to "true", |
There was a problem hiding this comment.
Bug: Commented-out debug code leftover from testing
The commented-out SENTRY_AUTO_INIT environment variable appears to be a leftover from development. The diff shows it was changed from "false" to "true" while remaining commented out, indicating this was part of local testing and wasn't meant to be committed. As the PR reviewer noted, this line doesn't contribute anything to the test and could be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
resolves: #4941
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps