Remove mention of sentry-native submodule#4377
Merged
Conversation
The Android NDK support was moved from sentry-java to sentry-native in #3189 and since then sentry-java has not had submodules.
chromy
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
romtsn
approved these changes
May 8, 2025
Member
romtsn
left a comment
romtsn
left a comment
There was a problem hiding this comment.
thanks, this is indeed not relevant anymore!
Member
|
@chromy JFYI we usually add _#skip-changelog_ to the PR description when there's no need for a changelog entry so Danger is happy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
As far as I can tell the Android NDK support was moved from sentry-java to sentry-native in #3189 and since then sentry-java has not had submodules.
💚 How did you test it?
Pure docs change so no tests.
📝 Checklist
sendDefaultPIIis enabled.