Skip to content

Report dropped spans#3528

Merged
stefanosiano merged 4 commits into
mainfrom
feat/report-dropped-spans
Jul 1, 2024
Merged

Report dropped spans#3528
stefanosiano merged 4 commits into
mainfrom
feat/report-dropped-spans

Conversation

@stefanosiano

@stefanosiano stefanosiano commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

📜 Description

added span data category for client reports
added dropped span report when recording lostEnvelopeItem added dropped span report on beforeSend and eventProcessor filtering (SentryClient) and backpressure and sampleRate (Hub)

💡 Motivation and Context

Closes #3527

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano
added span data category for client reports
997f774 
added dropped span report when recording lostEnvelopeItem
added dropped span report on beforeSend and eventProcessor filtering (SentryClient) and backpressure and sampleRate (Hub)
@github-actions

github-actions Bot commented Jun 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against adcfd03

@stefanosiano
stefanosiano marked this pull request as ready for review June 28, 2024 15:43
@stefanosiano
stefanosiano requested a review from cleptric June 28, 2024 15:43
@github-actions

github-actions Bot commented Jun 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 399.60 ms 472.17 ms 72.57 ms
Size 1.70 MiB 2.28 MiB 593.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baaf637 462.32 ms 579.22 ms 116.90 ms
28c9a83 416.98 ms 479.90 ms 62.92 ms
201048a 418.62 ms 481.67 ms 63.05 ms
7ab32b6 373.62 ms 480.61 ms 106.99 ms
b172d4e 352.92 ms 446.50 ms 93.58 ms
3d8bd2b 364.76 ms 469.98 ms 105.22 ms
1e05e43 411.00 ms 467.29 ms 56.29 ms
c554ca2 383.78 ms 449.84 ms 66.06 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms

App size

Revision Plain With Sentry Diff
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
28c9a83 1.70 MiB 2.28 MiB 592.00 KiB
201048a 1.70 MiB 2.28 MiB 592.32 KiB
7ab32b6 1.70 MiB 2.27 MiB 584.63 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
1e05e43 1.70 MiB 2.28 MiB 590.89 KiB
c554ca2 1.70 MiB 2.27 MiB 582.25 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB

Previous results on branch: feat/report-dropped-spans

Startup times

Revision Plain With Sentry Diff
0bd6ff3 429.51 ms 497.54 ms 68.03 ms
8007b45 374.00 ms 435.50 ms 61.50 ms

App size

Revision Plain With Sentry Diff
0bd6ff3 1.70 MiB 2.28 MiB 593.54 KiB
8007b45 1.70 MiB 2.28 MiB 593.48 KiB

markushi
markushi requested changes Jul 1, 2024
View reviewed changes

@markushi markushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, but I think I found one high issue, see my comments.

Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryClient.java Outdated
@stefanosiano @markushi
Apply suggestions from code review
00ba78d 
Co-authored-by: Markus Hintersteiner <[email protected]>
@adinauer

adinauer commented Jul 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Can you please also take care of merging this into the 8.x.x branch 🙏 (most likely via main)

@stefanosiano
stefanosiano enabled auto-merge (squash) July 1, 2024 13:47
@stefanosiano
stefanosiano merged commit edf4a58 into main Jul 1, 2024
@stefanosiano
stefanosiano deleted the feat/report-dropped-spans branch July 1, 2024 14:02
@stefanosiano

stefanosiano commented Jul 1, 2024

Copy link
Copy Markdown
Contributor Author

Can you please also take care of merging this into the 8.x.x branch 🙏 (most likely via main)

#3536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushi markushi markushi approved these changes
@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner
@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner
@cleptric cleptric Awaiting requested review from cleptric

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Report dropped spans in client reports

3 participants

@stefanosiano @adinauer @markushi