Skip to content

Comments

Remove sentry-native submodule again; ignore failing test#3525

Merged
adinauer merged 5 commits into8.x.xfrom
feat/potel-29-remove-sentry-native-again
Jun 26, 2024
Merged

Remove sentry-native submodule again; ignore failing test#3525
adinauer merged 5 commits into8.x.xfrom
feat/potel-29-remove-sentry-native-again

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jun 26, 2024 •
edited
Loading

#skip-changelog

📜 Description

  • Remove sentry-native submodule again
  • Ignore a failing test, we'll revisit this for the next release

💡 Motivation and Context

Seems to have resurfaced due to auto merge bringing it back. It was removed in https://github.com/getsentry/sentry-java/pull/3189/files#diff-359faa0e4a4584b6ac04835e8df52961f6b7b2eb4ba0962c5ac5c2b4ef45832c

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0a2e577

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.76 ms 444.66 ms 65.90 ms
Size 1.70 MiB 2.29 MiB 599.38 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
9428efa 389.31 ms 481.67 ms 92.37 ms
9f2c855 424.20 ms 506.34 ms 82.14 ms
6f16882 426.16 ms 494.15 ms 67.99 ms
dcad3c9 400.04 ms 479.67 ms 79.62 ms
34db09f 362.68 ms 443.02 ms 80.34 ms
3e1e45b 373.72 ms 439.33 ms 65.60 ms
a373f02 372.81 ms 432.96 ms 60.15 ms

App size

Revision Plain With Sentry Diff
9428efa 1.70 MiB 2.28 MiB 597.68 KiB
9f2c855 1.70 MiB 2.28 MiB 596.32 KiB
6f16882 1.70 MiB 2.28 MiB 596.37 KiB
dcad3c9 1.70 MiB 2.28 MiB 596.35 KiB
34db09f 1.70 MiB 2.28 MiB 596.37 KiB
3e1e45b 1.70 MiB 2.28 MiB 596.32 KiB
a373f02 1.70 MiB 2.28 MiB 596.35 KiB

Previous results on branch: feat/potel-29-remove-sentry-native-again

Startup times

Revision Plain With Sentry Diff
8accc81 418.34 ms 479.68 ms 61.34 ms
1783959 360.79 ms 420.50 ms 59.71 ms

App size

Revision Plain With Sentry Diff
8accc81 1.70 MiB 2.29 MiB 599.38 KiB
1783959 1.70 MiB 2.29 MiB 599.38 KiB

@adinauer adinauer changed the title Change POTel span origin Remove sentry-native submodule again Jun 26, 2024
@adinauer adinauer changed the title Remove sentry-native submodule again Remove sentry-native submodule again; ignore failing test Jun 26, 2024
@adinauer adinauer merged commit 783e112 into 8.x.x Jun 26, 2024
@adinauer adinauer deleted the feat/potel-29-remove-sentry-native-again branch June 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn Awaiting requested review from romtsn

@markushi markushi Awaiting requested review from markushi

1 more reviewer

@stefanosiano stefanosiano stefanosiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adinauer @stefanosiano