POTEL 20 - Use SpanOptions.startTimestamp in Span constructor#3498
Merged
POTEL 20 - Use SpanOptions.startTimestamp in Span constructor#3498
SpanOptions.startTimestamp in Span constructor#3498Conversation
…pes-merge-2-add-scopes
…ainScopes to rootScopes
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 20 - Use `SpanOptions.startTimestamp` in `Span` constructor ([#3498](https://github.com/getsentry/sentry-java/pull/3498))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
lbloder
reviewed
Jun 24, 2024
Collaborator
There was a problem hiding this comment.
There are quite a few commented lines starting from 475. Do we still need them for reference?
Member
Author
There was a problem hiding this comment.
Yeah, kept it for reference, when implementing certain features that are still missing.
lbloder
approved these changes
Jun 24, 2024
Collaborator
lbloder
left a comment
lbloder
left a comment
There was a problem hiding this comment.
Left a note about some commented code in SentryTracer.
Otherwise LGTM 👍
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove
startTimestampctor param and instead useSpanOptions.startTimestamp💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps