Kw/app start span for hybrid SDKs#3454
Merged
Merged
Conversation
krystofwoldrich
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
June 3, 2024 07:40
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6d2b2e | 392.55 ms | 467.50 ms | 74.95 ms |
| c7e2fbc | 393.98 ms | 478.24 ms | 84.27 ms |
| 4e260b3 | 388.40 ms | 468.98 ms | 80.58 ms |
| 28c9a83 | 366.20 ms | 433.88 ms | 67.67 ms |
| baaf637 | 418.39 ms | 496.86 ms | 78.47 ms |
| 283d83e | 416.81 ms | 497.22 ms | 80.41 ms |
| 283d83e | 348.44 ms | 392.06 ms | 43.62 ms |
| 0bf143e | 368.35 ms | 437.47 ms | 69.12 ms |
| 86f0096 | 368.63 ms | 446.92 ms | 78.29 ms |
| 619c9b9 | 428.23 ms | 514.66 ms | 86.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6d2b2e | 1.72 MiB | 2.27 MiB | 555.05 KiB |
| c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| 4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
| 28c9a83 | 1.70 MiB | 2.28 MiB | 592.00 KiB |
| baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| 283d83e | 1.72 MiB | 2.29 MiB | 577.69 KiB |
| 283d83e | 1.72 MiB | 2.29 MiB | 577.69 KiB |
| 0bf143e | 1.72 MiB | 2.29 MiB | 576.50 KiB |
| 86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
| 619c9b9 | 1.70 MiB | 2.28 MiB | 592.12 KiB |
Previous results on branch: kw/appStartSpanForHybridSDKs
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 27c9de3 | 368.88 ms | 473.28 ms | 104.40 ms |
| c9f1bb9 | 417.57 ms | 476.24 ms | 58.67 ms |
| d52f826 | 430.57 ms | 475.76 ms | 45.19 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 27c9de3 | 1.70 MiB | 2.28 MiB | 592.12 KiB |
| c9f1bb9 | 1.70 MiB | 2.28 MiB | 592.12 KiB |
| d52f826 | 1.70 MiB | 2.28 MiB | 592.12 KiB |
krystofwoldrich
changed the title
added 2 commits
June 3, 2024 16:38
…artSpanForHybridSDKs
Contributor
Author
|
@buenaflor This the same app start helper as for iOS. Again, please review the code from Flutter point of view. |
markushi
approved these changes
Jun 4, 2024
markushi
left a comment
markushi
left a comment
Member
There was a problem hiding this comment.
Nice one, looks good! Please have a look at my comments, especially the one about accepting only valid timespans.
Contributor
|
works on flutter 👍 looks good to me |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR adds a new method to the HybridSDKs interface which returns serializable app start data including span structures.
This can be used in Flutter (replacing current custom impl), React Native and other hybrid SDKs like Unity, Capacitor and others.
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog