Do not always write startup crash marker#3409
Merged
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0404ea3 | 394.73 ms | 461.79 ms | 67.06 ms |
| d007225 | 365.63 ms | 438.24 ms | 72.62 ms |
| c7e2fbc | 372.00 ms | 461.71 ms | 89.71 ms |
| 8838e01 | 387.41 ms | 467.00 ms | 79.59 ms |
| 4e29063 | 384.14 ms | 447.74 ms | 63.60 ms |
| 4e260b3 | 388.40 ms | 468.98 ms | 80.58 ms |
| c7e2fbc | 393.98 ms | 478.24 ms | 84.27 ms |
| 95a98b5 | 379.14 ms | 420.80 ms | 41.66 ms |
| a33b076 | 390.44 ms | 460.29 ms | 69.85 ms |
| 2465853 | 422.61 ms | 491.20 ms | 68.58 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0404ea3 | 1.72 MiB | 2.29 MiB | 577.52 KiB |
| d007225 | 1.70 MiB | 2.27 MiB | 586.31 KiB |
| c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| 8838e01 | 1.72 MiB | 2.29 MiB | 578.15 KiB |
| 4e29063 | 1.72 MiB | 2.29 MiB | 578.38 KiB |
| 4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
| c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| 95a98b5 | 1.70 MiB | 2.27 MiB | 586.31 KiB |
| a33b076 | 1.70 MiB | 2.28 MiB | 592.32 KiB |
| 2465853 | 1.70 MiB | 2.27 MiB | 583.82 KiB |
markushi
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
CurrentDateProvideruses uptime millis, therefore we were always writing the crash marker file and always blocking SDK init. This is a regression from when we introduced app start spans💡 Motivation and Context
Found out this accidentally while testing
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps