Fix UncaughtExceptionHandlerIntegration Memory Leak#3398
Merged
Conversation
…stered use its default exception handler instead
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| baaf637 | 462.32 ms | 579.22 ms | 116.90 ms |
| 28c9a83 | 416.98 ms | 479.90 ms | 62.92 ms |
| 201048a | 418.62 ms | 481.67 ms | 63.05 ms |
| 7ab32b6 | 373.62 ms | 480.61 ms | 106.99 ms |
| b172d4e | 352.92 ms | 446.50 ms | 93.58 ms |
| 3d8bd2b | 364.76 ms | 469.98 ms | 105.22 ms |
| 1e05e43 | 411.00 ms | 467.29 ms | 56.29 ms |
| c554ca2 | 383.78 ms | 449.84 ms | 66.06 ms |
| 0bd723b | 375.20 ms | 452.41 ms | 77.20 ms |
| 99a51e2 | 405.11 ms | 479.65 ms | 74.54 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| 28c9a83 | 1.70 MiB | 2.28 MiB | 592.00 KiB |
| 201048a | 1.70 MiB | 2.28 MiB | 592.32 KiB |
| 7ab32b6 | 1.70 MiB | 2.27 MiB | 584.63 KiB |
| b172d4e | 1.72 MiB | 2.29 MiB | 578.09 KiB |
| 3d8bd2b | 1.72 MiB | 2.29 MiB | 577.53 KiB |
| 1e05e43 | 1.70 MiB | 2.28 MiB | 590.89 KiB |
| c554ca2 | 1.70 MiB | 2.27 MiB | 582.25 KiB |
| 0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
| 99a51e2 | 1.72 MiB | 2.29 MiB | 576.34 KiB |
lbloder
marked this pull request as ready for review
May 1, 2024 17:11
lbloder
requested review from
adinauer,
markushi,
romtsn and
stefanosiano
as code owners
May 1, 2024 17:11
romtsn
reviewed
May 2, 2024
adinauer
approved these changes
May 2, 2024
adinauer
left a comment
adinauer
left a comment
Member
There was a problem hiding this comment.
Thanks for taking care of this!
…tion.java Co-authored-by: Roman Zavarnitsyn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon registration check if an
UncaughtExceptionHandlerIntegrationis already set asdefaultUncaughtExceptionHandler, if so, set itsdefaultExceptionHandleras the default of the newUncaughtExceptionHandlerIntegration.💡 Motivation and Context
Fixes #3266
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps