Fix timing metric value different from span duration#3368
Merged
Conversation
duration of timing metric of MetricsApi now equals span duration local metrics aggregator is fetch directly from the span in the timing api
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0810952 | 364.51 ms | 468.08 ms | 103.57 ms |
| baaf637 | 462.32 ms | 579.22 ms | 116.90 ms |
| 1e05e43 | 411.00 ms | 467.29 ms | 56.29 ms |
| 86f0096 | 371.86 ms | 439.78 ms | 67.92 ms |
| baaf637 | 401.69 ms | 428.12 ms | 26.43 ms |
| 937879e | 400.98 ms | 482.84 ms | 81.86 ms |
| 1ae2ec6 | 353.85 ms | 419.71 ms | 65.85 ms |
| 606074f | 385.10 ms | 428.24 ms | 43.14 ms |
| 9119d59 | 407.12 ms | 509.64 ms | 102.52 ms |
| 93a76ca | 391.54 ms | 475.65 ms | 84.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0810952 | 1.72 MiB | 2.27 MiB | 558.21 KiB |
| baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| 1e05e43 | 1.70 MiB | 2.28 MiB | 590.89 KiB |
| 86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
| baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| 937879e | 1.72 MiB | 2.27 MiB | 558.42 KiB |
| 1ae2ec6 | 1.70 MiB | 2.27 MiB | 584.63 KiB |
| 606074f | 1.70 MiB | 2.27 MiB | 582.26 KiB |
| 9119d59 | 1.70 MiB | 2.27 MiB | 583.84 KiB |
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
stefanosiano
marked this pull request as ready for review
April 17, 2024 11:16
stefanosiano
requested review from
adinauer,
markushi and
romtsn
as code owners
April 17, 2024 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
removed timing from IMetricsAggregator
duration of timing metric of MetricsApi now equals span duration
local metrics aggregator is fetch directly from the span in the timing api
💡 Motivation and Context
Fixes #3289 and #3290
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps